Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor file matcher improvements #9886

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Minor file matcher improvements #9886

merged 3 commits into from
Feb 4, 2025

Conversation

mnonnenmacher
Copy link
Member

See the commit messages for details.

@mnonnenmacher mnonnenmacher requested a review from a team as a code owner February 2, 2025 13:06
@mnonnenmacher mnonnenmacher enabled auto-merge (rebase) February 2, 2025 13:07
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.21%. Comparing base (abe81f8) to head (3506c58).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...li/src/main/kotlin/commands/ListLicensesCommand.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #9886   +/-   ##
=========================================
  Coverage     68.21%   68.21%           
- Complexity     1293     1295    +2     
=========================================
  Files           250      250           
  Lines          8849     8849           
  Branches        920      920           
=========================================
  Hits           6036     6036           
  Misses         2424     2424           
  Partials        389      389
Flag Coverage Δ
funTest-docker 65.14% <ø> (ø)
funTest-non-docker 33.54% <0.00%> (+0.17%) ⬆️
test-ubuntu-24.04 35.98% <80.00%> (ø)
test-windows-2022 35.96% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth
Copy link
Member

sschuberth commented Feb 2, 2025 •
edited
Loading

Why not align the other way around? That would better match Kotlin's Regex.matches() .

@mnonnenmacher
Copy link
Member Author

Why not align the other way around? That would better match Kotlin's Regex.matches() .

I don't have a preference, I just wanted them to be the same. So do you prefer matches?

@sschuberth
Copy link
Member

I don't have a preference, I just wanted them to be the same. So do you prefer matches?

Yes, I think I'd slightly prefer that.

@mnonnenmacher
docs(utils): Remove a broken KDoc reference
2cd7beb 
Constructor arguments cannot be referenced from class docs if they are
not also properties.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher
docs(utils): Fix a reference to a static function
e6387fb 
Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher force-pushed the file-matcher-improvements branch from b3020f5 to bb61a91 Compare February 3, 2025 17:00
@mnonnenmacher
refactor(utils)!: Rename FileMatcher.matches to matches
3506c58 
This aligns the name of the static functions with the class function
which is also called `matches`. Also, this better aligns with framework
functions like `Regex.matches`.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher force-pushed the file-matcher-improvements branch from bb61a91 to 3506c58 Compare February 3, 2025 17:01
@mnonnenmacher
Copy link
Member Author

I don't have a preference, I just wanted them to be the same. So do you prefer matches?

Yes, I think I'd slightly prefer that.

Done.

@mnonnenmacher mnonnenmacher merged commit 48b638f into main Feb 4, 2025
26 checks passed
@mnonnenmacher mnonnenmacher deleted the file-matcher-improvements branch February 4, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fviernau fviernau fviernau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnonnenmacher @sschuberth @fviernau